Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZettaiReido] Result対応 #441

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

h-mikisato
Copy link
Contributor

絶対隷奴の #423 対応です。

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #441 (9080879) into master (20b9e89) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   95.21%   95.24%   +0.03%     
==========================================
  Files         288      288              
  Lines       18698    18679      -19     
==========================================
- Hits        17803    17791      -12     
+ Misses        895      888       -7     
Impacted Files Coverage Δ
lib/bcdice/game_system/ZettaiReido.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/LiveraDoll.rb 97.43% <0.00%> (-1.10%) ⬇️
lib/bcdice/game_system/BattleTech.rb 99.40% <0.00%> (+0.01%) ⬆️
lib/bcdice/command/parsed.rb 97.05% <0.00%> (+0.39%) ⬆️
lib/bcdice/game_system/Skynauts.rb 100.00% <0.00%> (+0.59%) ⬆️
lib/bcdice/command/parser.rb 93.95% <0.00%> (+2.42%) ⬆️
lib/bcdice/game_system/TrinitySeven.rb 100.00% <0.00%> (+2.46%) ⬆️
lib/bcdice/game_system/FutariSousa.rb 100.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b9e89...9080879. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getResult にoutputを渡して合成するのではなく、 getResult はあくまでResultとそれに合ったテキスト (Result.success("成功")など)を返し、メインのメソッド側で Result#textを合成して欲しいです。

@ysakasin ysakasin merged commit d5dffa9 into bcdice:master Apr 30, 2021
@ysakasin
Copy link
Member

ありがとうございます!

@h-mikisato h-mikisato deleted the feature/result_zettai_reido branch November 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants